[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

ME: Re: Re: Re: A tale of two paradigms


> My implementation seems to be very close to the pull paradigm, but again
> I'll have to take a closer look at it.

A few early comments after taking a first look at the source:

- The KxmlRpcWriter could probably be replaced by  
  org.kxml.io.XmlWriter without much effort. This would 
  also allow to switch between XML and WBXML 
  encoding.

- "Truely" switching to the pull paradigm could probably 
  eliminate the need of the explicit stack and the Value class.

- There seems to be a minor problem with date encoding since
  leading zeros seem not to be filled for months or days < 10.
  You may consider using org.kobjects.isodate.IsoDate, it is
  LGPLed and can be distributed together with kxmlrpc.
  (see http://kobjects.org). If the corresponding functionality
  is needed elsewhere in the program, this may also reduce
  the overall MIDlet size.

Best,
Stefan